/nft-explorer new feature - search on sale for any token #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2025 07:22
ihomp
reviewed
Jul 11, 2025
| @@ -121,7 +137,7 @@ export default function NftsComponent({ | |||
|
|
|||
| const listTabList = [ | |||
| { value: 'nfts', label: t('tabs.all') }, | |||
| { value: 'onSale', label: t('tabs.onSale', { nativeCurrency }) } | |||
There was a problem hiding this comment.
instead of removing the usage of t('tabs.onSale') we need to update it in all languages.
we can just make it as "Listed".
t('tabs.onSale', { nativeCurrency }) will become t('tabs.onSale')
ihomp
requested changes
Jul 11, 2025
components/NftsComponent.js
Outdated
| @@ -638,7 +677,7 @@ export default function NftsComponent({ | |||
| (isValidTaxon(taxonQuery) ? ' ' + taxonQuery : '') + | |||
| (ownerQuery ? ', ' + t('table.owner') + ': ' + ownerQuery : '') + | |||
| (activeView === 'list' ? ' ' + t('tabs.list') : '') + | |||
| (listTab === 'onSale' ? ' ' + t('tabs.onSale', { nativeCurrency }) : '') + | |||
| (listTab === 'onSale' ? ' ' + 'On sale for tokens': '') + | |||
components/NftsComponent.js
Outdated
| /> | ||
| </div> | ||
| )} | ||
| {!nftExplorer && saleCurrencyIssuer && saleCurrency && ( |
There was a problem hiding this comment.
why would we make it different for !nftExplorer?
we should keep the logic as we had it without a separation.
do for /nfts/ /nft-explorer it will be the same
|
@ihomp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
we need to replace it with token selector, so user can see nfts on sale for any token